Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AVRO-2579]: Fix test by sorting fields for deterministic order #667

Merged
merged 1 commit into from
May 26, 2020
Merged

[AVRO-2579]: Fix test by sorting fields for deterministic order #667

merged 1 commit into from
May 26, 2020

Conversation

contextshuffling
Copy link
Contributor

Make sure you have checked all steps below.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    • modifies the unit tests to make it more stable

Commits

  • My commits all reference Jira issues in their subject lines

@probot-autolabeler probot-autolabeler bot added the Java Pull Requests for Java binding label Oct 6, 2019
@contextshuffling contextshuffling changed the title [AVRO-2579]: Fix tests by sorting fields for deterministic order [AVRO-2579]: Fix test by sorting fields for deterministic order Oct 6, 2019
@contextshuffling
Copy link
Contributor Author

CI failed for weird reason. The test passes locally

@Fokko
Copy link
Contributor

Fokko commented Oct 11, 2019

Thanks @contextshuffling

I've restarted the CI, sometimes Travis has some intermittent issues.

@contextshuffling
Copy link
Contributor Author

@Fokko any follow-ups on this PR?

@Fokko
Copy link
Contributor

Fokko commented Dec 1, 2019

Looks like that Travis had some network issues, I've restarted the CI (again).

@contextshuffling
Copy link
Contributor Author

Potentially related: apache/pulsar#6247

@Fokko
Copy link
Contributor

Fokko commented Feb 17, 2020

Thanks @contextshuffling. Can you rebase against latest master?

@contextshuffling
Copy link
Contributor Author

@Fokko Sorry for the late reply. should be good now

@Fokko
Copy link
Contributor

Fokko commented Mar 2, 2020

We got a failing master again. Normally this doesn't happen that often, but I guess you are very unlucky @contextshuffling I'll check if I can fix master, let me get back to you.

@contextshuffling
Copy link
Contributor Author

@Fokko I saw in the log that ImportError: cannot import name 'ContextManager'. First of all, this is in python which I do not see how my changes would touch it. After some search, this looks to be something newly added after py3.6. Is the CI image out-of-dated? Above it, the project itself builds and run all the test successfully and then the CI crashed due to this python script.

@Fokko
Copy link
Contributor

Fokko commented Mar 16, 2020

@contextshuffling sorry for the late reply. Can you rebase onto master? Current master is green again.

@dkulp dkulp merged commit a6a0346 into apache:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Awaiting requested review from Fokko

Assignees
No one assigned
Labels
Java Pull Requests for Java binding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@contextshuffling @Fokko @dkulp